Repository navigation
Update the developer container to work with HTTPS - #9
Merged
Merged
Conversation
Serve VSCode, the GLVis viewer, and the GLVis websocket bridge behind an nginx reverse proxy on the tutorial port (3000), routed by path. This lets the container sit behind an HTTPS load balancer that forwards only one port. - nginx routes / to VSCode (moved to 3001), /glvis/ to the viewer site, and /glvis-ws to the websocket bridge (with upgrade headers) - patch the cloned GLVis viewer to use a same-origin ws(s):// URL at /glvis-ws, fixing mixed-content blocking on https
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/glvis/live/and proxy/glvis-wsto the internal GLVis bridge.?socket=/glvis-ws, so the viewer automatically connects through the public secure route.Example
The tutorial link:
https://<subdomain>.mfem.hpcic.training/glvis/live/?socket=/glvis-wsloads the GLVis viewer and automatically connects to:
wss://<subdomain>.mfem.hpcic.training/glvis-wsNginx proxies that connection to
glvis-browser-serveron internal port8080.Testing
I have tested on my fork: tdrwenski#2 with images https://github.com/tdrwenski?tab=packages&repo_name=containers in combination with GLVis/glvis-js#39. Locally you have vscode at
http://localhost:3000andhttp://localhost:3000/glvis/live/?socket=/glvis-wsconnects automaticallyQuestion
The develop docker container still works locally like this but technically if you run locally you don't need nginx. Do you think this is okay or would you prefer a different "tutorial" docker image? or is the developer image mostly for the tutorial?