Repository navigation
WSS mixed content fix for HTTPS - #39
Merged
Merged
Conversation
Hardcoded ws:// was blocked as mixed content on https pages. Derive the scheme from the page, and let Host include a path (e.g. host/glvis-ws) to reach the socket via a reverse proxy. Plain host:port use is unchanged.
tdrwenski
marked this pull request as draft
September 4, 2026 18:35
tdrwenski
marked this pull request as ready for review
September 4, 2026 20:31
Contributor
Author
|
After discussing with @najlkin, now pushed a change to redesign the socket connection dialog. Let me know what you think, see screenshots: |
najlkin
reviewed
Sep 10, 2026
Co-authored-by: Jan Nikl <nikl1@llnl.gov>
Contributor
Author
|
Updated screenshots with path option removed-- The standard default connection: This is what gets filled with URL http://localhost:8000/live/?socket=/foo |
najlkin
approved these changes
Sep 14, 2026
najlkin
left a comment
najlkin
left a comment
Contributor
There was a problem hiding this comment.
Thanks @tdrwenski 👍 , looks great! 🎉
tzanio
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wss://when the viewer is served over HTTPS, preventing mixed-content failures.?socket=support to preconfigure and automatically connect the viewer.Example
Opening:
https://example.org/glvis/live/?socket=/glvis-wsautomatically connects to:
wss://example.org/glvis-wsA plain Host and Port workflow remains supported for direct connections.
See also: mfem/containers#9