Skip to content

docs(pabcd-state): clarify #333 advisory notes - #335

Merged
lidge-jun merged 1 commit into
devfrom
docs/pabcd-state-333-advisory-notes
Oct 31, 2026
Merged

lidge-jun merged 1 commit into
devfrom
docs/pabcd-state-333-advisory-notes

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Follow-up to #333 by @LilMGenius — small wording fixes found during review.

  • CHANGELOG: the fix(pabcd-state): send PreToolUse advisories as context only #333 entry said all three PreToolUse advisories reach the model again; the friction gate hook lives only under hooks/_deprecated/ and is not installed by default, so that part now applies when that hook is enabled.
  • pabcd-state src/cli.ts (+ rebuilt dist/cli.js): comments on the pre-tool-use-idle-edit and pre-tool-use-friction branches still described the old allow envelopes; they now describe the context-only envelope (additionalContext, no permissionDecision).

Comments/docs only; no behavior change. npm run build reproduces dist byte-for-byte.

Follow-up to #333 (thanks @LilMGenius):
- CHANGELOG: the friction gate advisory only applies when the opt-in
  hooks/_deprecated friction hook is enabled.
- pabcd-state cli.ts comments now describe the context-only envelope
  (additionalContext, no permissionDecision) instead of the old allow
  envelopes; dist rebuilt.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T01:58:51.482603Z 2391c77 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 31, 2026
@lidge-jun
lidge-jun merged commit dad6498 into dev Oct 31, 2026
14 checks passed
@lidge-jun
lidge-jun deleted the docs/pabcd-state-333-advisory-notes branch October 31, 2026 02:06
This was referenced Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant