Repository navigation
Conversation
schford
added a commit
to schford/python_poollab
that referenced
this pull request
Oct 22, 2026
schford
added a commit
to schford/python_poollab
that referenced
this pull request
Oct 22, 2026
- hacs.json: drop zip_release/filename (no release workflow runs on the fork) - manifest.json: version 1.3.1-sf1 - README: fork note naming the carried upstream PRs dala318#70-dala318#73 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions such as
TimeoutError()have an empty string representation, so PoolLab currently logsUnknown error communicating with API:without identifying the failure.Report request timeouts explicitly and explain automatic retry. The message is independent of the configured deadline, since a timeout may originate in either the HTTP/GraphQL client or the coordinator. For other failures, retain the exception type and provide fallback text when its message is empty. Authentication handling and polling behavior are unchanged.
Validation:
tests/test_coordinator.pyin this environment because its existingConfigEntryconstruction lackssubentries_data. The same collection error occurs on unchanged upstream code; this PR leaves that separate test compatibility issue untouched.git diff --checkpasses.The error-message change can be merged independently of #73: it does not change the timeout setting or require a timeout constant. The real deadline regression test expires the timeout context without depending on its configured duration.