Repository navigation
Conversation
schford
added a commit
to schford/python_poollab
that referenced
this pull request
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconfiguring PoolLab schedules a reload through both its update listener and async_update_reload_and_abort. Home Assistant warns that this combination stops working in 2026.12. Reauthentication can likewise reload twice because it updates the entry and then explicitly reloads it.
Remove the redundant update listener and its callback. Both config-flow paths already perform the required reload, including when credentials are unchanged. This follows the documented option to retain config-flow reloads and remove the listener, and avoids requiring a newer config-flow helper.
Validation:
Fixes #68.
Reference: https://developers.home-assistant.io/blog/2026/05/07/config-entry-listener-together-with-reloading-methods/
No polling, timeout, sensor-write or error-message changes are included; the patch attached to #69 does not address this reload issue. The existing Hassfest translation failure and test collection compatibility issue are handled separately in #71.