Repository navigation
Conversation
DecodeFloat64 and DecodeFloat32 cast the uint64 through int64 first. 9223372036854775808 came back negative, and 18446744073709551615 came back as -1. A uint64 is converted with its own magnitude. 42 and a negative int64 are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecodeFloat64andDecodeFloat32turned a uint64 through int64 first.9223372036854775808came back as-9223372036854775808, and18446744073709551615came back as-1. Both are positive values that fit in a float. A uint64 is now converted with its own magnitude.42is still42.-3is still-3.Test plan
TestDecodeUint64AsFloatfails on tip:DecodeFloat64(9223372036854775808) = -9.223372036854776e+18go test -count=1 ./...passes