Repository navigation
Conversation
The PowerShell completer ran the whole command line, including the word being completed, and showed every suggestion it got back. So `myapp st<Tab>` offered all subcommands, and `myapp sync<Tab>` offered the arguments of sync instead of completing sync itself. Like the bash and fish scripts, pass only the words before the cursor, plus the current word when it is a flag, and keep only the suggestions that start with the current word. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The PowerShell completion script ran the whole command line, including the word being completed, and showed every suggestion it got back. PowerShell doesn't filter native completer results, so
myapp st<Tab>offered every subcommand, andmyapp sync<Tab>offered the arguments ofsyncinstead of completingsyncitself. Like the bash and fish scripts, it now passes only the words before the cursor (plus the current word when it's a flag) and keeps only suggestions that start with the current word. It also fixes the order of the scriptblock's parameter names; native completers get$wordToComplete, $commandAst, $cursorPosition.Which issue(s) this PR fixes:
None filed.
Testing
TestCompletionPowershellCompletesCurrentWordruns the generated script throughTabExpansion2in Windows PowerShell with a.cmdstand-in for the app. It's skipped on other platforms.Release Notes
I used Claude Code to write this change.