Repository navigation
[Feature] The anti-aliasing picker offers the temporal modes, and the tone-map menu no curve - #182
Merged
untoldengine merged 1 commit intoOct 19, 2026
Conversation
… tone-map menu no curve untoldengine/UntoldEngine#1359 adds the `.taa` and `.msaaTaa` anti-aliasing modes and the `.none` tone-map operator; the editor's option enums switch over the engine's exhaustively, so it stopped building against that branch. "TAA" and "MSAA+TAA" join the segmented control, mapped both ways, and selecting either shows an Advanced group with the temporal resolve's history weight, clip gamma and jitter scale from `TAAParams.shared`, undoable like the FXAA and SMAA sliders; "None" joins the tone-map operator menu, mapped both ways to `TonemapOperator.none`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
untoldengine/UntoldEngine#1359 adds two anti-aliasing modes,
.taaand.msaaTaa, and the tone-map operator.none; the editor's two option enums switch over those engine enums exhaustively, so the editor does not build against that branch. This adds the cases:TAAParams.shared: history weight, clip gamma and jitter scale, as undoable sliders like the FXAA and SMAA ones.TonemapOperator.none(the scene's linear colour as it is, which the engine PR measured as RealityKit's response in a mixed-immersion space).Depends on untoldengine/UntoldEngine#1359: the editor builds against the engine's
develop, so this PR's build check fails until that one has merged. Merge order: #1359 first, then re-run this PR's checks (or push to it) and merge. Verified locally by building the editor against that engine branch (1,302 editor tests pass).Checklist
swift buildwith the dependency in edit mode)Architectural notes
The editor keeps its own option enums (
EditorAntiAliasingOption,EditorTonemapOption) mapping to and from the engine's, so the engine's enums can grow without the picker's labels changing; this follows that pattern. The TAA sliders read and writeTAAParams.shareddirectly through the existingUndoableEffectSlider, the way the FXAA and SMAA sliders do;TAAParamsis not anObservableObject, so the sliders keep their own state while dragging and the engine value is the source of truth.