Repository navigation
docking: Allow non-pressure reveal near the screen edge - #2788
Open
Michaelmascarenhas90 wants to merge 1 commit into
Open
Michaelmascarenhas90 wants to merge 1 commit into
Michaelmascarenhas90 wants to merge 1 commit into
Conversation
The non-pressure dwell path currently requires the pointer to land on the exact outermost pixel of the monitor. On some display layouts, this makes the hidden dock difficult to reveal without enabling pressure. Accept pointer positions within four pixels of the relevant screen edge while keeping the existing work-area limits along that edge. This makes hover reveal more reliable for docks on any side of a monitor.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When pressure-to-show is disabled, the dwell path requires the pointer to be on the exact outermost pixel of the monitor. This makes the hidden dock difficult to reveal on some display layouts.
Change
Accept the pointer within four pixels of the corresponding screen edge. Keep the existing work-area bounds along the edge and apply the same tolerance to all four dock positions.
Verification
node --check docking.jsgit diff --checkmake checkcould not run locally becauseeslintis not installed.Related: #2780 addresses pointer sampling and an X11 hover regression. This change focuses only on the edge tolerance.