Repository navigation
Preserve integer precision in YAML output - #280
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
|
|
nathanjcochran
approved these changes
Oct 28, 2026
nathanjcochran
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for the contribution. Please sign the contributor license agreement and mark this PR ready for review. After that, I'd be happy to merge 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
YAML output normalizes values through JSON to honor JSON field tags, but decoding into
anywith encoding/json changes all numbers into float64. An int64 such as 9007199254740993 is silently rounded to 9007199254740992; signed and unsigned limits are affected too.Change
Decode the JSON intermediate with the existing YAML decoder so integer values retain their precision while JSON field names, omissions, and custom marshaling remain authoritative. Add scalar/nested integer and string/fraction/boolean/null controls, plus a full CLI backup-list case. Update the existing YAML backup fixture to expect its exact integer size rather than floating-point notation.
Validation