Repository navigation
i18n - pulling from tx - #1071
Merged
Merged
Conversation
ogajduse
marked this pull request as draft
September 29, 2026 16:22
ogajduse
marked this pull request as ready for review
September 30, 2026 15:12
adamlazik1
reviewed
Oct 5, 2026
Addresses the review on theforeman#1071. "The number of failed invocations is:" came back from Transifex as "Le nombre des invocations est :" - the qualifier "failed" was dropped, so on the job-results page the French labelled the failure count as the total. Restored to "Le nombre d'invocations échouées est :". The neighbouring "selected invocations" string kept its qualifier, which is what made the loss visible. "Open all failed runs on this page (%s)" gained a stray space inside the parentheses, rendering as "(42 )". Both fixed in the .po and in the generated JS catalog, and the .mo regenerated. Also drops a duplicate translator credit line. Translated message count is unchanged at 632.
Contributor
|
Thanks @ogajduse ! |
ogajduse
added a commit
to ogajduse/foreman_remote_execution
that referenced
this pull request
Oct 19, 2026
Ports the translation values from a0ba922 (theforeman#1071) for msgids this branch has. A cherry-pick conflicts and would be wrong: the branches have diverged in source (6 msgids exist only here, 21 only on master), so taking master's catalogs would drop the 6 and add 21 strings this branch does not have. Values only - the .pot is untouched, no msgids added or removed, and all 617 entries stay translated in fr/ja/ko/zh_CN. JS catalogs regenerated with rake plugin:po_to_json; .mo with msgfmt.
ogajduse
added a commit
to ogajduse/foreman_remote_execution
that referenced
this pull request
Oct 19, 2026
Ports the translation values from a0ba922 (theforeman#1071) for msgids this branch has. A cherry-pick conflicts and would be wrong: the branches have diverged in source (6 msgids exist only here, 21 only on master), so taking master's catalogs would drop the 6 and add 21 strings this branch does not have. Values only - the .pot is untouched, no msgids added or removed, and all 617 entries stay translated in fr/ja/ko/zh_CN. JS catalogs regenerated with rake plugin:po_to_json; .mo with msgfmt.
adamlazik1
pushed a commit
that referenced
this pull request
Oct 20, 2026
Ports the translation values from a0ba922 (#1071) for msgids this branch has. A cherry-pick conflicts and would be wrong: the branches have diverged in source (6 msgids exist only here, 21 only on master), so taking master's catalogs would drop the 6 and add 21 strings this branch does not have. Values only - the .pot is untouched, no msgids added or removed, and all 617 entries stay translated in fr/ja/ko/zh_CN. JS catalogs regenerated with rake plugin:po_to_json; .mo with msgfmt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the second round of Satellite 6.20 / Foreman 5.0 translations from Transifex.
The four languages supported downstream (fr, ja, ko, zh_CN) go from 611 to 632 translated strings each; other languages get whatever the community has contributed since the last pull. The
.potchanges only in timestamps and source line references — no strings added or removed.Extraction and compilation ran in a container with Foreman
developand this plugin mounted (rake plugin:gettext,plugin:po_to_json,make -C locale mo-files).