Repository navigation
Increase OceanBase CE startup timeout to 5 minutes - #12114
Conversation
Boot to "boot success!" takes ~55-60s on GitHub runners, so the default 60s timeout made tests flaky. The image README notes bootstrap may take up to five minutes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
OceanBaseCEContainerwaits forboot success!with the default 60s startup timeout. On GitHub runners, boot takes ~55–60s, so the module's tests fail intermittently withTimed out waiting for log output matching '.*boot success!.*'. The main CI run on 2026-10-05 failed 7 of 10 attempts; the passing ones took 57.6s and 60.3s.The log message is the right readiness signal: the image's
start.shonly prints it after the tenant accepts SQL connections and init SQL has run. Boot is just slow. This PR raises the wait strategy's startup timeout to 5 minutes, following the image README ("The bootstrap procedure may take up to five minutes"). The MINI and NORMAL modes are slower than SLIM, which the tests use.User-visible change: a container that hangs during boot now fails after 5 minutes instead of 60s. Failed boots still fail fast because the container exits (
EXIT_WHILE_ERRORdefaults to true). The timeout can still be overridden viawithStartupTimeout(...).Local cold boots (SLIM mode, Docker Desktop) took 42–44s to
boot success!. ASELECT 1succeeded ~0.7s earlier, so an extra SQL readiness check would add nothing.🤖 Generated with Claude Code
Summary by CodeRabbit