Repository navigation
Require next-major targets for breaking changes - #2153
Open
jar-stripe wants to merge 5 commits into
Open
jar-stripe wants to merge 5 commits into
jar-stripe wants to merge 5 commits into
Conversation
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
jar-stripe
marked this pull request as ready for review
September 18, 2026 20:32
jar-stripe
requested review from
justiny-stripe
and
a lite review from Copilot
and removed request for
a team
September 18, 2026 20:32
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Inspect renamed changefiles and pin the Hark action to an audited commit.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR adds CI enforcement requiring breaking Hark changes to target sdk-release/next-major.
Changes:
- Adds paginated changefile discovery and Hark inspection.
- Updates workflow permissions and pull request triggers.
- Documents the behavior with a patch changefile.
File summaries
| File | Summary |
|---|---|
.hark/changes/2026-09-18_jar_require-next-major-target.change.md |
Documents the workflow behavior. |
.github/workflows/rules.yml |
Implements branch-target validation and workflow updates. |
Review details
Suppressed comments (1)
.github/workflows/rules.yml:56
- Filtering only for
status == "added"lets a breaking changefile bypass this check when it is introduced via a rename: the pull request files API reports the destination asstatus: "renamed", so it will never reachhark inspecteven though the PR adds a new.hark/changes/*.change.mdpath. Include renamed entries (or otherwise inspect every changed non-deleted changefile) before applying the branch restriction.
if ! paths=$(jq -sc '[.[] | select(.status == "added") | .filename | select(test("^[.]hark/changes/[^/]+[.]change[.]md$"))]' <<< "$files" 2>&1); then
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zacchua-stripe
approved these changes
Sep 19, 2026
Comment on lines
+78
to
+82
| if [[ "$major_paths" != "[]" && "$BASE_REF" != "sdk-release/next-major" ]]; then | ||
| affected_paths=$(jq -r 'join(", ")' <<< "$major_paths") | ||
| echo "::error::Major Hark changefiles must target sdk-release/next-major. Retarget this pull request from '$BASE_REF' to 'sdk-release/next-major'. Affected files: $affected_paths" | ||
| exit 1 | ||
| fi |
Contributor
There was a problem hiding this comment.
Same question as stripe/stripe-dotnet#3456 (comment) !
Committed-By-Agent: goose Orbit-Session-Id: c9e24cd7-9c07-436c-8756-f6998b381745
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Breaking SDK changes must land on
sdk-release/next-majorso they do not enter the current major release frommaster.What?
sdk-release/next-major.sdk-release/next-majorintomaster.actionlint, and passes repository CI.See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.