Repository navigation
Merge to private-preview - #2903
Merged
zacchua-stripe merged 4 commits intoOct 17, 2026
Merged
Conversation
* Add API v2 search result pagination Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Send v2 Search limit as a query parameter Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Preserve v2 Search page URLs Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Add v2 Search changefile Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Refine v2 Search changefile Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Restore v2 Search change title Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Refine auto-pagination change wording Committed-By-Agent: goose Orbit-Session-Id: ac7fd08a-e385-4498-800e-21f51d3e4ad6 * Update StripeResource.ts * fixed lint error * Address review feedback on v2 Search auto-pagination Fix the v2 search pagination snapshot so it no longer corrupts bigint int64_string params: coerce through the request schema first (matching the real request pipeline), then deep-clone with the same stringify logic RequestSender uses to serialize the body, instead of a raw JSON round-trip that threw on bigint and lost Decimal duck-typing. Expose V2SearchResult/V2SearchResultPromise through the public entry points (stripe.core.ts, stripe.esm.node.ts, stripe.cjs.node.ts) and add type-only coverage in typescriptTest.ts. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Clean up comments in autoPagination.ts Removed comments about request parameter handling. --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Bind the publish job to the protected release environment so npm trusted publishing can reject OIDC tokens issued to unreviewed feature-branch workflows. Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
….ts (#2900) * Hand-write V2List/V2SearchResult namespace exports in stripe.cjs.node.ts These four lines were sdk-codegen's only hardcoded, unconditional literals in renderStripeClientInterfaceCJSExports — everything else it renders is driven by actual resource data. V2SearchResult/ V2SearchResultPromise duplicated this file's own existing hand-written aliases of the same name, breaking custom-objects Node SDK generation with a TypeScript duplicate-identifier error the moment a custom object gets a Search method (stripe/stripe-cli-ts-plugins#415). Move all four into the hand-maintained section next to ApiList/ ApiListPromise, where they belong as core infrastructure types rather than spec-derived resources. Companion sdk-codegen PR removes the generator's unconditional emission of these four. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Committed-By-Agent: claude * Shorten changefile Committed-By-Agent: claude * Delete .hark/changes/2026-10-16_jar_hand-write-v2-list-search-exports.change.md --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
zacchua-stripe
requested review from
justiny-stripe
and removed request for
a team
October 16, 2026 23:55
zacchua-stripe
enabled auto-merge
October 16, 2026 23:55
jar-stripe
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
What?
See Also
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.