Repository navigation
Increase timeout limit for integration tests - #2891
Merged
Merged
Conversation
mark-kogan-stripe
requested review from
zacchua-stripe
and removed request for
a team
October 14, 2026 17:25
mark-kogan-stripe
force-pushed
the
increaseTimeout
branch
from
October 14, 2026 17:26
bda24ab to
23de341
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The unrelated package lockfile should be removed or submitted separately.
0 open findings
What changed in this PR
Increases the integration test timeout from 50 to 90 seconds.
Changes:
- Raises the Mocha integration-test timeout.
- Adds an unrelated AWS workload identity lockfile.
| File | Description |
|---|---|
test/Integration.spec.ts |
Increases integration timeout to 90 seconds. |
packages/aws-workload-identity/package-lock.json |
Adds an unrelated dependency lockfile. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mark-kogan-stripe
requested review from
jar-stripe
and removed request for
zacchua-stripe
October 14, 2026 17:26
jar-stripe
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
50 seconds doesn't consistently provide enough time for integration tests to run end to end
What?
increase timeout limit to 90 seconds
Configuration
skip-changefile: This PR is not a user-facing change, so there's no changefile.