Repository navigation
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Summary
Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage |  |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
🟡 Minor · Use the ARM64 Epoxy variable for the aarch64 IPA builder. · ipa-image-build.yml:535
.github/workflows/ipa-image-build.yml:535
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winUse the ARM64 Epoxy variable for the aarch64 IPA builder.
The aarch64 IPA job still uses
Ubuntu-24.04-arm64, so release-specific changes toHOST_IMAGE_BUILD_IMAGE_ARM64_EPOXYdo not affect it. This can select an incorrect or unavailable builder image for Epoxy.Proposed fix
- aio_vm_image = "Ubuntu-24.04-arm64" + aio_vm_image = "${{ vars.HOST_IMAGE_BUILD_IMAGE_ARM64_EPOXY }}"
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: stackhpc/stackhpc-kayobe-config
- Branch: update-host-image-build-image
- File: .coderabbit.yaml
- Commit: 9265e8b
- Layers: Repository YAML
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
351420ea-e8b0-4fcd-9d9b-311b7558b5b3
📒 Files selected for processing: 4
.github/workflows/amphora-image-build.yml.github/workflows/ipa-image-build.yml.github/workflows/overcloud-host-image-build.ymletc/kayobe/ansible/maintenance/octavia-amphora-image-build.yml
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📜 Review details
⏰ Context from checks skipped due to timeout: 6
- GitHub Check: stackhpc/check
- GitHub Check: Ansible 2.17 lint with Python 3.10
- GitHub Check: Tox pep8 with Python 3.12
- GitHub Check: Tox releasenotes with Python 3.12
- GitHub Check: Ansible 2.18 lint with Python 3.12
- GitHub Check: Tox docs with Python 3.12
🧰 Additional context used
🪛 Checkov (3.3.25)
etc/kayobe/ansible/maintenance/octavia-amphora-image-build.yml
[low] 40-117: Ensure block is handling task errors properly
(CKV2_ANSIBLE_3)
🪛 zizmor (1.30.1)
.github/workflows/amphora-image-build.yml
[warning] 2-272: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
[info] 108-108: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
.github/workflows/ipa-image-build.yml
[warning] 2-791: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
[info] 163-163: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
.github/workflows/overcloud-host-image-build.yml
[warning] 2-879: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
[info] 171-171: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
[info] 614-614: code injection via template expansion (template-injection): may expand into attacker-controllable code
(template-injection)
🔇 Additional comments: 3
.github/workflows/ipa-image-build.yml: 1
163-163: LGTM!.github/workflows/overcloud-host-image-build.yml: 1
171-171: LGTM!Also applies to: 614-614
etc/kayobe/ansible/maintenance/octavia-amphora-image-build.yml: 1
82-87: LGTM!
8d877dd to
b188543
Compare
* Remove hardcoded build image value in IPA build workflow * Update workflows to use an Epoxy-specific build image * Update amphora building playbook to pin setuptools to 80.10.2
b188543 to
cad55ad
Compare
|
I will go fix this in our 2026.1 branch as well—moving to release specific image means this PR won't break anything there though so they don't need to be merged together. |
This branch was successfully deployed
1 participant
To be able to build CentOS Stream 10 IPA images the build image used in the workflow needed to be advanced from Ubuntu 22.04 to 24.04—at the time this was hardcoded in, but we should probably revert back to using repo vars to set it.
Because the existing var is shared with Caracel and Gazpacho workflows a new release-specific var has been used, this will need to be updated on the repository:
HOST_IMAGE_BUILD_IMAGE_EPOXY=>Ubuntu-24.04HOST_IMAGE_BUILD_IMAGE_ARM64_EPOXY=>Ubuntu-24.04-arm64Test builds with the updated image: