Repository navigation
Save proposed MCMC steps - #88
manueltabreu wants to merge 5 commits into
Conversation
| }else{ | ||
| fSamples.FillTree(fCurrentStep, fCurrentVal, accepted); | ||
| } | ||
| fSamples.Fill(fCurrentStep, fCurrentVal, accepted); |
There was a problem hiding this comment.
the fChain gets initialised in InitialiseHistograms, which only gets called in Fill(). So I think we need fSamples.Fill(fCurrentStep, fCurrentVal, accepted); to be before the if statement. alternatively could put the same if(!fInitialised) inside FillTree, but I think this is simpler
Looks great otherwise!
|
I think if you just address those new inline comments that should get the new test running and passing. But then it would be great to extend that test to use the new functionality by enabling SetSaveProposedSteps(true), retrieving the saved chain, and checking that it contains the expected number of entries In an ideal world we'd also check it contains the exact right values (proposed or accepted), but it's probably tricky to do that in a test as the step proposals aren't deterministic |
To resolve the issue opened by Daniel a few months ago.