Repository navigation
Parse timestamps independently of interpreter version - #40
Merged
Merged
Conversation
datetime.fromisoformat is not version-stable. On Python 3.10 it accepts fractional seconds only at exactly 3 or 6 digits, so 14:02:00.9Z raises, while 3.11+ accepts it. The unparseable branch returned the string verbatim, so canonicalization silently did nothing on 3.10. The consequence is that identical evidence produced different digests on different interpreters. That breaks the content-addressed cache and would have made eval corpus entries collected under one interpreter unreproducible under another. Timestamps are now parsed with an explicit pattern covering the separator, Z and z, offsets with and without a colon, optional seconds, and any fractional precision, then rebuilt into a form every supported interpreter parses identically. Caught by CI: 3.12 passed and 3.10 failed. The matrix earned its place on the first real disagreement.
Tickmark — evidence collectedControl evaluation is not wired up yet. This is the evidence the engine sees.
Notices
Provenance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datetime.fromisoformat is not version-stable. On Python 3.10 it accepts
fractional seconds only at exactly 3 or 6 digits, so 14:02:00.9Z raises, while
3.11+ accepts it. The unparseable branch returned the string verbatim, so
canonicalization silently did nothing on 3.10.
The consequence is that identical evidence produced different digests on
different interpreters. That breaks the content-addressed cache and would have
made eval corpus entries collected under one interpreter unreproducible under
another.
Timestamps are now parsed with an explicit pattern covering the separator, Z
and z, offsets with and without a colon, optional seconds, and any fractional
precision, then rebuilt into a form every supported interpreter parses
identically.
Caught by CI: 3.12 passed and 3.10 failed. The matrix earned its place on the
first real disagreement.