Repository navigation
Fix self-referential evidence and lint - #39
Merged
Merged
Conversation
The sticky comment contains an evidence digest. Collecting it put the tool's previous output into its own input, so the bundle changed on every run and the digest never stabilised on an unchanged pull request. Post digest A, next run collects the comment containing A, produces B, updates the comment to B, next run produces C. The content-addressed cache would miss every time and every re-run would look like new evidence. Found by reading the collected bundle from PR #37, which contains the comment from its own earlier run. Local runs matched only because --output never posts. Marker moved to constants so the collector can exclude what the renderer writes. Exclusion is recorded as a notice rather than silent. Other bots' comments are kept: only Tickmark's own output is self-reference. Regression test asserts both that the digest survives a post-collect cycle and that it would drift without the filter.
Tickmark — evidence collectedControl evaluation is not wired up yet. This is the evidence the engine sees.
Notices
Provenance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sticky comment contains an evidence digest. Collecting it put the tool's
previous output into its own input, so the bundle changed on every run and the
digest never stabilised on an unchanged pull request.
Post digest A, next run collects the comment containing A, produces B, updates
the comment to B, next run produces C. The content-addressed cache would miss
every time and every re-run would look like new evidence.
Found by reading the collected bundle from PR #37, which contains the comment
from its own earlier run. Local runs matched only because --output never posts.
Marker moved to constants so the collector can exclude what the renderer writes.
Exclusion is recorded as a notice rather than silent. Other bots' comments are
kept: only Tickmark's own output is self-reference.
Regression test asserts both that the digest survives a post-collect cycle and
that it would drift without the filter.