Repository navigation
Release 0.30.3: right-click a toolbar button for its settings, Settings opens at one size - #88
Merged
Merged
Conversation
…ck to their own settings Settings sized itself once when it opened, measuring only the page that was showing. Qt lays out only the visible page, and a hidden Viewer page still had its width from before the window was sized, so its Build plate columns looked as if they fit. Opened from Customize toolbar, Updates or About, Settings came out narrower than from the Settings button, and Viewer's Build plate box went one under the other. It is now measured with the Viewer page laid out, whatever page it opens on, so every way of opening gives the same size. Right-click on a toolbar button offers that button's settings, then Customize toolbar...: Settings -> Settings, Theme -> Appearance, Screenshot -> Files (Screenshots box), Open in slicer -> Slicer, Export STL -> Files (Export STL box), Plate -> Viewer (Build plate box), Check / View / Measure -> Viewer (Measure, View and Check box). Home, Open, Fit and the empty part of the toolbar keep Customize toolbar... only. A box is scrolled into view on small screens. Each right-click menu is now freed after use.
The two columns are separate grids, so a short row on one side (the X, Y and Z axes tick box) beside a taller one (the numbers' spacing dropdown) moved every row under it up by the difference: Plate sat 3 px above Grid lines every here and 4 px on Windows, which failed test_build_plate_box_has_two_columns there (it allowed 3). Side by side, row n is now as tall on both sides; one under the other, each keeps its own heights. The test now allows 1 px, so it catches this on every system.
…gs opens at one size Each toolbar button's right-click now offers one item: buttons with settings of their own open Settings at those settings; the Settings gear (a click already opens Settings), Home, Open, Fit and an empty spot offer Customize toolbar... Two items on some buttons and one on others was confusing. Version 0.30.3, changelog in English, Arabic and Dutch, and the right-click table in the README and on the website (English, Arabic, Dutch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-click a toolbar button for its settings
Each button's right-click offers one item:
On small screens the box is scrolled into view. Each right-click menu is now freed after use (it used to stay in memory).
Fixed: Settings opened at different sizes
Settings sized itself once when it opened, measuring only the page that was showing. Qt lays out only the visible page, and the hidden Viewer page still had an old width, so its Build plate columns looked as if they fit. Opened from Customize toolbar, Updates or About, the window came out narrower and Build plate went one column under the other. It is now measured with the Viewer page laid out, so every way of opening gives the same size.
Fixed: Build plate rows didn't line up
The two columns are separate grids, so a tick box beside a taller dropdown shifted every row below it: 3 px on Linux, 4 px on Windows, which failed
test_build_plate_box_has_two_columnsin a local Windows build. Side by side, each row is now equally tall on both sides; the test now allows 1 px instead of 3.Also
tests/test_settings_open.py(same size from every page, sections, right-click items).Generated by Claude Code