Repository navigation
Conversation
For an unknown length, lengthUnknown stores the bar width in config.max, so GetMax and GetMax64 returned the width (40 by default) while State() reported Max as -1. Return -1 from both getters in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a bar of unknown length,
GetMaxandGetMax64return the bar width, whileState().Maxsays-1:lengthUnknown()storesconfig.widthinconfig.maxso the spinner can use it, and the getters return that field as is.State()already checksignoreLengthand reports-1, so this makesGetMax64do the same, andGetMaxnow callsGetMax64. Nothing inside the package calls the getters, so rendering is unchanged.Added
TestGetMaxUnknownLength, coveringNewOptions(-1)andChangeMax(-1)/ChangeMax(50). It fails before the change withGetMax() = 40, want -1. The rest of the suite is unchanged. On Windows,TestSpinnerClearOnFinishfails both with and without this change.Related, but left out on purpose:
AddMaxon an unknown-length bar adds to the width (NewOptions(-1).AddMax(100)gives a max of 140), and itsif p.config.max == -1check never matches. It's not obvious what the right result is there, so I can do that as a follow-up if you want.