Repository navigation
Calopacketcontainer ffarawmodules - #4508
Merged
pinkenburg merged 2 commits intoOct 28, 2026
Merged
pinkenburg merged 2 commits into
pinkenburg merged 2 commits into
Conversation
Contributor
Walkthrough
Priority: Merge Risk:
 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to GitHub limitations.
ClockDiffCheck.cc:183-220
offline/framework/ffarawmodules/ClockDiffCheck.cc:183-220
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy liftPer-packet FEM event check cannot catch an outlier packet within a detector.
At
ClockDiffCheck::process_event,CheckFemEventNr(calopacket)runs on oneCaloPacketnode at a time. A packet that holds one FEM module gives the helper a one-element event-number set, so the check always passes. If that packet's FEM event number differs from the other packets of the same detector, it stays in the output even whendelBadPktsis enabled.The removed container logic selected the majority
FEMEVTNRacross the packets of each detector and removed mismatching packets whendelBadPktswas set. Restore detector-wide majority selection before the per-node loop. This requires a packet-to-detector grouping that the inspected code does not provide. Per-node checking does not replace it.
-
-
- Source mode: Auto
- Repository: sPHENIX-Collaboration/coresoftware
- Branch: master
- File: .coderabbit.yaml
- Commit: 911a978
- Layers: Repository YAML
- Review profile: CHILL
- Plan: Advanced
- Run ID:
a0b33267-1d14-47cc-9603-6d5e4c40d659
-
offline/framework/ffarawmodules/CemcCheck.ccoffline/framework/ffarawmodules/CemcCheck.hoffline/framework/ffarawmodules/ClockDiffCheck.ccoffline/framework/ffarawmodules/ClockDiffCheck.hoffline/framework/ffarawmodules/HcalCheck.ccoffline/framework/ffarawmodules/HcalCheck.hoffline/framework/ffarawmodules/Makefile.amoffline/framework/ffarawmodules/MbdCheck.ccoffline/framework/ffarawmodules/MbdCheck.hoffline/framework/ffarawmodules/SEpdCheck.ccoffline/framework/ffarawmodules/SEpdCheck.hoffline/framework/ffarawmodules/ZdcCheck.ccoffline/framework/ffarawmodules/ZdcCheck.h
-
- offline/framework/ffarawmodules/MbdCheck.h
- offline/framework/ffarawmodules/ZdcCheck.h
- offline/framework/ffarawmodules/ClockDiffCheck.h
- offline/framework/ffarawmodules/SEpdCheck.cc
- offline/framework/ffarawmodules/SEpdCheck.h
- offline/framework/ffarawmodules/HcalCheck.h
- offline/framework/ffarawmodules/CemcCheck.h
- offline/framework/ffarawmodules/HcalCheck.cc
- offline/framework/ffarawmodules/MbdCheck.cc
- offline/framework/ffarawmodules/CemcCheck.cc
- offline/framework/ffarawmodules/ZdcCheck.cc
- offline/framework/ffarawmodules/ClockDiffCheck.cc
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
-
Build & test reportReport for commit 9908833ee4850920c57858c8ef42a0b0d30310c0:
Automatically generated by sPHENIX Jenkins continuous integration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
This PR removes the CaloPacketContainer from framework/ffarawmodules, Modifying the ClockDiffCheck and removing obsolete modules which did not use the new CaloPacket class
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Motivation / context
This change removes
CaloPacketContainer-based modules fromframework/ffarawmodulesas the codebase moves toward individualCaloPacketnodes. The supplied description marks the change as a new feature.Key changes
ClockDiffChecknow checks individualCaloPacketnodes and no longer declares the container-levelFillCaloClockDiffmethod.delBadPktsis enabled,ClockDiffCheckresets packets with XMIT clock mismatches. It also resets packets that failCheckFemEventNr.CemcCheck,HcalCheck,MbdCheck,SEpdCheck, andZdcCheckmodules and their headers.Makefile.amto remove those modules and addBcoRangeCheckto the build lists.Potential risk areas
delBadPkts.Possible future improvements
delBadPktsenabled or disabled.AI-generated change descriptions can contain errors. Use the source and project knowledge to verify details. Test results were not supplied.