Repository navigation
Caloskimmer simplify - #4501
Merged
pinkenburg merged 3 commits intoOct 26, 2026
Merged
Caloskimmer simplify#4501
Conversation
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Select and process packet sources offline/packages/Skimmers/CaloPacket/CaloPacketSkimmer.h, offline/packages/Skimmers/CaloPacket/CaloPacketSkimmer.cc |
The skimmer removes set_offlineflag, its associated fields, and offline-container handling. It reads packets from a PRDF event when present, and from standalone CaloPacket nodes otherwise. A non-data PRDF event returns ABORTEVENT; per-packet discard handling remains. |
Sequence Diagram(s)
sequenceDiagram
participant Skimmer as CaloPacketSkimmer
participant PRDF as PRDF Event
participant Nodes as standalone CaloPacket nodes
Skimmer->>PRDF: Check for event
alt PRDF event exists
Skimmer->>PRDF: Check event type and read packets
PRDF-->>Skimmer: Event packets
else No PRDF event
Skimmer->>Nodes: Read packets in configured ID range
Nodes-->>Skimmer: Standalone packets
end
Possibly related PRs
- sPHENIX-Collaboration/coresoftware#4499: Both changes remove
CaloPacketContainerhandling and use PRDF events or directCaloPacketnodes. - sPHENIX-Collaboration/coresoftware#4500: That PR removes
CaloPacketContainerhandling fromMbdReco; this PR removes it fromCaloPacketSkimmer.
Priority:
Merge Risk: 
5ece7
-
The changed packet-selection path has no identified issue requiring a fix before merge.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Build & test reportReport for commit 5ece70b743a6dff5df165890a7461af16282bd7a:
Automatically generated by sPHENIX Jenkins continuous integration |
pinkenburg
merged commit Oct 26, 2026
fd705f9
into
sPHENIX-Collaboration:master
18 of 22 checks passed
This was referenced Oct 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
This PR removes the obsolete CaloPacketContainer object from the CaloPacketSkimmer
TODOs (if applicable)
Links to other PRs in macros and calibration repositories (if applicable)
Motivation
Remove the obsolete
CaloPacketContainerhandling fromCaloPacketSkimmerand simplify packet access. The change also follows an “include what you use” approach.Key changes
processDetectorchecks for a PRDFEvent. It reads packets from the event when available, and reads standaloneCaloPacketnodes when no PRDF event is available.ABORTEVENT. Missing or empty packets continue to mark the detector event for discard.set_offlineflagmethod, and the related private flags.Potential risk areas
CaloPacketnodes are used when no PRDF event exists. Validate this behavior with the intended input formats.ABORTEVENT, while a missing PRDF event no longer aborts immediately. This can affect event selection.Possible future improvements
AI-generated summaries can make mistakes. This summary is based on the supplied description and inspected source; use contributor judgment when validating behavior.