Repository navigation
Adding Centrality to KFParticle - #4456
BrentMartin-ISU wants to merge 0 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: sPHENIX-Collaboration/coresoftware/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
52618145-ba11-47dd-9ac4-21356ba7108d
📒 Files selected for processing (3)
offline/packages/KFParticle_sPHENIX/KFParticle_nTuple.ccoffline/packages/KFParticle_sPHENIX/KFParticle_nTuple.hoffline/packages/KFParticle_sPHENIX/KFParticle_sPHENIX.cc
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: sPHENIX-Collaboration/coresoftware/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
1d7cd4d6-fddb-476d-ae1d-4fca2ac903c0
📒 Files selected for processing (2)
offline/packages/KFParticle_sPHENIX/KFParticle_nTuple.ccoffline/packages/KFParticle_sPHENIX/KFParticle_nTuple.h
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
|
Your PR is failing the CI because of compilation errors, see |
Build & test reportReport for commit ba5bd66a3d55d785556c28ab114d0098a681b9c6:
Automatically generated by sPHENIX Jenkins continuous integration |
ba5bd66 to
911a978
Compare




Types of changes
What kind of change does this PR introduce? (Bug fix, feature, ...)
Adding the ability for KFParticle to display and calculate centrailty data
TODOs (if applicable)
Finish implementation and test to confirm accuracy then share with collaboration
Links to other PRs in macros and calibration repositories (if applicable)
Motivation
Add MBD centrality to KFParticle decay-tree output so analyses can use centrality with reconstructed data. The draft description says implementation and accuracy testing remain incomplete.
Key changes
useCentrality()setter andm_use_centrality_nTupleflag.centrality_mbdtree branch.mbd_NSbin fromCentralityInfoduring event filling.-1ifCentralityInfois missing or any daughter has a nonzero bunch crossing. Set it to-2if the node lacks thembd_NSbin.-lcentrality.Potential risk areas
centrality_mbdbranch changes the tree schema when enabled. Downstream readers may need to handle it.-1and-2as sentinel values, not physical centralities.Possible future improvements
CentralityInfonode,mbd_NSbin, bunch-crossing condition, and sentinel values.AI-generated change descriptions can contain errors. Use best judgment and verify these details against the source and collaboration review.