Skip to content

Drop stray whitespace from sector and category names - #2740

Merged
maebeale merged 1 commit into
mainfrom
maebeale/squish-tag-names
Oct 18, 2026
Merged

maebeale merged 1 commit into
mainfrom
maebeale/squish-tag-names

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 one normalizes line on two models, with specs

Sector and category names now drop stray whitespace when saved, because a trailing space on prod's "Grief/Loss " quietly kept six tag aliases from ever matching it.

What is the goal of this PR and why is this important?

  • Prod had 12 sectors saved with a trailing space (cleaned by hand on 2026-10-17).
  • MySQL ignores trailing spaces when comparing, but Ruby lookups don't, so a stray space made a tag invisible to code matching names in Ruby.

How did you approach the change?

  • normalizes :name squishes on Sector and Category, so every save path is covered.
  • Existing rows change only when next saved; prod's known cases are already clean.

Anything else to add?

🤖 Generated with Claude Code

Prod's Grief/Loss sector was saved as "Grief/Loss ", and since MySQL ignores
trailing spaces in comparisons but Ruby doesn't, code matching names in Ruby
couldn't find it. Squishing on save keeps a stray space from hiding a tag.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@maebeale
maebeale marked this pull request as ready for review October 18, 2026 02:47
@maebeale
maebeale merged commit 487494a into main Oct 18, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/squish-tag-names branch October 18, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant