Repository navigation
Count values set on inner nodes of COMPS_ObjRTree - #162
Merged
m-blaha merged 1 commit intoOct 27, 2026
Conversation
m-blaha
reviewed
Oct 27, 2026
| } | ||
| if (ended == 3) { //keys equals; data replacement | ||
| if (rtdata->data == NULL) | ||
| rt->len++; |
Member
There was a problem hiding this comment.
That only handles transition NULL -> value. Should we handle also NULL -> NULL (where the len is incorrectly increased) and value -> NULL (where the len should be decreased)?
e.g.
if (rtdata->data == NULL && ndata != NULL)
rt->len++;
else if (rtdata->data != NULL && ndata == NULL)
rt->len--;
Setting a key which already exists as an inner node without a value (e.g. "a" after "ab" and "ac") replaced the NULL data without incrementing COMPS_ObjRTree.len, so len() of the dict was too small. Also decrement the count when an existing value is replaced with NULL, and keep it unchanged when NULL is replaced with NULL. Signed-off-by: hanjinpeng <hanjinpeng@kylinos.cn>
prownd
force-pushed
the
count-values-set-on-inner-nodes-of-COMPS_ObjRTree-s01
branch
from
October 27, 2026 10:45
02e5acc to
66eb414
Compare
Contributor
Author
|
Thanks, good point. Updated as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting a key which already exists as an inner node without a value (e.g. "a" after "ab" and "ac") replaced the NULL data without incrementing COMPS_ObjRTree.len, so len() of the dict was too small.