Repository navigation
[perf] Speed up DeadCode rules with lazy docblock/walk and instanceof guard before scope type lookup - #8668
Merged
Conversation
… guard before scope type lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance refactor of 3 rules. No behavior change - all fixtures pass unchanged.
RemoveUnusedPromotedPropertyRector- the constructor docblock is now parsed lazily, only when a promoted property is actually being removed, so constructors with no removable promoted property no longer parse their docblock.RemoveRedundantTypeCheckRector- in bothrefactorBooleanOr()andrefactorBooleanAnd(), the cheapBooleanNot/FuncCallinstanceof check now runs beforeisNonTypedFromParam()(a scope type lookup).RemoveDefaultValueFromAssignedPropertyRector-hasEarlyReturn()(a constructor subtree walk) is now evaluated lazily, only once a property is actually eligible for its default to be removed; it is cached, so classes with no eligible property skip the walk entirely.Reordering is safe: the moved instanceof checks are side-effect-free bail conditions, and each lazily-computed value is created before its first use and is constant for the node.