Repository navigation
Label dictionary keys in react-native (#59818) - #59818
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D130071787. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
meta-codesync Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
Summary: Pull Request resolved: #59818 Labels unlabeled dictionary keys: `{[string]: T}` becomes `{[key: string]: T}`. In TypeScript, `{[string]: T}` is a computed property, not an index signature, so this prepares the code for `experimental.require_dictionary_key_label`, which requires the label. The label is documentation only and does not change any type. Generated by the `flow/nameIndexerKeys` codemod, run only on the keys that the flag reports, so computed keys like `{['a']: T}` are left alone. Keys inside comment types, and files whose formatting the codemod's printer would change, were labeled with a plain text insertion instead. Changelog: [Internal] Differential Revision: D130071787
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D130071787
branch
from
November 6, 2026 14:19
a80537d to
24c0c7f
Compare
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 24c0c7f When will my fix make it into a release? | How to file a pick request? |
Summary: Pull Request resolved: #59818 Labels unlabeled dictionary keys: `{[string]: T}` becomes `{[key: string]: T}`. In TypeScript, `{[string]: T}` is a computed property, not an index signature, so this prepares the code for `experimental.require_dictionary_key_label`, which requires the label. The label is documentation only and does not change any type. Generated by the `flow/nameIndexerKeys` codemod, run only on the keys that the flag reports, so computed keys like `{['a']: T}` are left alone. Keys inside comment types, and files whose formatting the codemod's printer would change, were labeled with a plain text insertion instead. Changelog: [Internal] Differential Revision: D130071787
meta-codesync
Bot
force-pushed
the
export-D130071787
branch
from
November 6, 2026 14:29
24c0c7f to
50fd5aa
Compare
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 50fd5aa When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in de05579 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Labels unlabeled dictionary keys:
{[string]: T}becomes{[key: string]: T}. In TypeScript,{[string]: T}is a computed property, not an index signature, so this prepares the code forexperimental.require_dictionary_key_label, which requires the label. The label is documentation only and does not change any type.Generated by the
flow/nameIndexerKeyscodemod, run only on the keys that the flag reports, so computed keys like{['a']: T}are left alone. Keys inside comment types, and files whose formatting the codemod's printer would change, were labeled with a plain text insertion instead.Changelog: [Internal]
Differential Revision: D130071787