Skip to content

Drop PropertyDescriptor type arguments that the upcoming non-generic builtin rejects #59814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Nov 5, 2026
Merged

Drop PropertyDescriptor type arguments that the upcoming non-generic builtin rejects #59814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/Libraries/Utilities/PolyfillFunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function polyfillObjectProperty<T>(
name: string,
getValue: () => T,
): void {
const descriptor = Object.getOwnPropertyDescriptor<$FlowFixMe>(object, name);
const descriptor = Object.getOwnPropertyDescriptor(object, name);
if (__DEV__ && descriptor) {
const backupName = `original${name[0].toUpperCase()}${name.slice(1)}`;
Object.defineProperty(object, backupName, descriptor);
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/src/private/webapis/dom/oldstylecollections/HTMLCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {setPlatformObject} from '../../webidl/PlatformObjects';
// IMPORTANT: The type definition for this module is defined in `HTMLCollection.js.flow`
// because Flow only supports indexers in classes in declaration files.

const REUSABLE_PROPERTY_DESCRIPTOR: {...PropertyDescriptor<unknown>, ...} = {
const REUSABLE_PROPERTY_DESCRIPTOR: {...PropertyDescriptor, ...} = {
value: {},
enumerable: true,
configurable: false,
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/src/private/webapis/dom/oldstylecollections/NodeList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {setPlatformObject} from '../../webidl/PlatformObjects';
// IMPORTANT: The Flow type definition for this module is defined in `NodeList.js.flow`
// because Flow only supports indexers in classes in declaration files.

const REUSABLE_PROPERTY_DESCRIPTOR: {...PropertyDescriptor<unknown>, ...} = {
const REUSABLE_PROPERTY_DESCRIPTOR: {...PropertyDescriptor, ...} = {
value: {},
writable: false,
};
Expand Down
Loading