Repository navigation
Bump SoLoader to 0.13.0 - #59813
Open
shamilovtim wants to merge 1 commit into
Open
Bump SoLoader to 0.13.0#59813shamilovtim wants to merge 1 commit into
shamilovtim wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
cortinico
requested changes
Nov 6, 2026
Comment on lines
-90
to
-94
| try { | ||
| SoLoader.init(context, OpenSourceMergedSoMapping.INSTANCE); | ||
| } catch (IOException error) { | ||
| throw new RuntimeException(error); | ||
| } |
Contributor
There was a problem hiding this comment.
Why are you removing this try/catch?
Contributor
Author
There was a problem hiding this comment.
SoLoader 0.13.0 changed that particular init overload so it no longer declares throws IOException.
https://github.com/meta/SoLoader/blob/v0.13.0/java/com/facebook/soloader/SoLoader.java#L366-L374
Previously, React Native caught IOException and wrapped it in RuntimeException. Now SoLoader does that itself on the inside for this particular overload.
Contributor
|
@shamilovtim can you rebase on top of master, the release should be out now |
shamilovtim
force-pushed
the
bump-soloader-0.13.0
branch
from
November 6, 2026 14:50
1e062a1 to
8cc8ec3
Compare
Contributor
Author
rebased |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump SoLoader from 0.12.1 to 0.13.0.
SoLoader 0.13.0 searches the installed ABI first. This fixes native library loading on x86_64 devices that run ARM libraries.
It also removes the checked
IOExceptionfrominit. Drop the catch block and unused import from the generated Java entry point, and update its existing expected output. The old catch causes javac to reject the generated source becauseinitno longer throwsIOException.Requested by @cortinico in SoLoader #155. See the 0.13.0 release notes.
Changelog
[ANDROID] [FIXED] - Update SoLoader to 0.13.0 to fix native library loading when the installed ABI differs from the first supported ABI.
Test plan
./gradlew -p packages/gradle-plugin :react-native-gradle-plugin:test --tests com.facebook.react.tasks.GenerateEntryPointTaskTest --console=plainpassed all 3 tests.git diff --checkpassed.soloader,annotationandnativeloader0.13.0 artifacts.IOExceptioncatch. The updated entry point compiles.A full React Native Android build was not run locally.