Repository navigation
Drop PropertyDescriptor type arguments that the upcoming non-generic builtin rejects - #59814
Merged
Merged
Conversation
…c builtin rejects Summary: Flow's builtin `PropertyDescriptor<T = unknown>` is becoming non-generic, as in TypeScript's `lib.es5.d.ts`: its `value`, `get` and `set` use `any`, and `Object.getOwnPropertyDescriptor` no longer takes a type argument. The new builtins reject `PropertyDescriptor<X>` annotations and `Object.getOwnPropertyDescriptor<X>(...)` calls. Remove those type arguments. Today's Flow accepts all of these sites without them. Nothing changes at runtime. Changelog: [Internal] Drop `PropertyDescriptor` type arguments. Differential Revision: D129956546
meta-cla
Bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129956546. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 4a851dd When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Flow's builtin
PropertyDescriptor<T = unknown>is becoming non-generic, as in TypeScript'slib.es5.d.ts: itsvalue,getandsetuseany, andObject.getOwnPropertyDescriptorno longer takes a type argument. The new builtins rejectPropertyDescriptor<X>annotations andObject.getOwnPropertyDescriptor<X>(...)calls.Remove those type arguments. Today's Flow accepts all of these sites without them.
Nothing changes at runtime.
Changelog: [Internal] Drop
PropertyDescriptortype arguments.Differential Revision: D129956546