Repository navigation
refactor: use x, defaultX and onXChange for state props - #983
Open
rohanchkrabrty wants to merge 2 commits into
Open
rohanchkrabrty wants to merge 2 commits into
rohanchkrabrty wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
1 task done
rohanchkrabrty
force-pushed
the
feat/change-event-details
branch
from
October 20, 2026 08:56
d888724 to
5b27067
Compare
1 task done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x,defaultXandonXChange. SelectsearchValue,defaultSearchValue,onSearchbecomeinputValue,defaultInputValue,onInputValueChange. DatePicker and RangePickeronSelectbecomesonValueChange. TouronStepChangebecomesonStepIndexChange, with the step indetails.step. DataViewonTableQueryChangebecomesonQueryChange.queryand FilterChipvaluewere read on the first render only. They are now controlled with Base UIuseControlled, anddefaultQueryanddefaultValueset the first value. DatePickervaluealso moves touseControlled.operationanddefaultOperation. DataView passes each filter'soperatorto its chip, so a query withoperator: 'neq'shows "is not".eventDetails. DatePicker, RangePicker, Tour, DataView and FilterChiponOperationChangepassdetailsfromcreateChangeDetails.Stacked on #979. Retarget to
mainafter it merges.Decisions
onOperationChange, now(operation, details).onValueChangekeepsdetails.operationfrom feat: pass a details object to change callbacks #979. Thedetails.reasoncomes from the operation Select.queryfrom outside replaces it only when the two differ, so a new empty filter chip stays. Aquerychange from outside does not callonQueryChange.onQueryChangein client mode too, so a controlled query works in both modes. Server mode still calls it on mount, asonTableQueryChangedid.details.reasonisnone, because the call runs after the state change.onValueChangeonly when the typed date differs from the value. A day click passes reasonitem-pressand a typed date passesinput-change.defaultOperationfalls back to the first operation, as before. FilterChip keeps the typed text of anumbercolumn, so1.and-stay editable under a controlledvalue.docs/rfcs/003anddocs/V1-migration.mdkeep the old names, since they record earlier releases. DataTable keepsqueryandonTableQueryChange.Overlap with open PRs
valueandsearchValue, RangePickervalueand DataViewviewtouseControlled. This PR does not redo that. It only renames Select's props and keeps RangePicker's mirror, so expect conflicts inselect-root.tsx,range-picker.tsxanddata-view.tsx.inputValueto the Base UI Combobox. fix: [select] pass searchValue to the autocomplete search input #968 does it for Select under the oldsearchValuename, so it needs the new names after this PR.