You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: correct type tokens, input prefix heights and typography docs - #981
Replace --rs-font-weight-semibold, which is not defined, with --rs-font-weight-medium in the Drawer title and the Fieldset legend. Both rendered at the inherited weight. The Drawer title now matches the Dialog title.
Replace the Fieldset legend's undefined --rs-font-size-base, --rs-line-height-base and --rs-letter-spacing-base with the regular tokens (14px / 20px). The legend took its size from the page.
Replace the undefined --rs-font-family in the PromptInput composer with --rs-font-body, the token other components use for body text. The composer took its parent's font.
Set the Input prefix and suffix heights to the design: 20px for small (was 16px) and 24px for large (was a fixed 22px that ignored scaling). Both use spacing tokens, so they follow scaling.
Match the typography token table to styles/typography.css: line-height-mini is 14px, line-height-t1 is 28px, and body and title letter spacing is in em.
Figma still has the old typography values (Body/Mini line height 16px, Title/T1 24px, letter spacing in px). A separate design task updates Figma to match the code.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
Typography documentation updates body and title token values. Styles for the drawer title, editor composer, fieldset legend, and input prefixes and suffixes also change.
Suggested reviewers:rohanchkrabrty
Priority: ⬇️ Low
Merge Risk:⚪ Minimal · up to 7dcdf
This PR updates typography and component sizing; the supplied review evidence identifies no concrete regression, so it is ready for normal checks.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title accurately summarizes the main changes to type tokens, input prefix heights, and typography documentation.
Description check
The description directly explains the token replacements, input height updates, and typography documentation changes in the changeset.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--rs-font-weight-semibold, which is not defined, with--rs-font-weight-mediumin the Drawer title and the Fieldset legend. Both rendered at the inherited weight. The Drawer title now matches the Dialog title.--rs-font-size-base,--rs-line-height-baseand--rs-letter-spacing-basewith the regular tokens (14px / 20px). The legend took its size from the page.--rs-font-familyin the PromptInput composer with--rs-font-body, the token other components use for body text. The composer took its parent's font.scaling). Both use spacing tokens, so they followscaling.styles/typography.css:line-height-miniis 14px,line-height-t1is 28px, and body and title letter spacing is inem.Figma still has the old typography values (
Body/Miniline height 16px,Title/T124px, letter spacing in px). A separate design task updates Figma to match the code.