Skip to content

fix: correct type tokens, input prefix heights and typography docs - #981

Open
Shreyag02 wants to merge 3 commits into
mainfrom
fix/token-values
Open

Shreyag02 wants to merge 3 commits into
mainfrom
fix/token-values

Conversation

@Shreyag02

@Shreyag02 Shreyag02 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Replace --rs-font-weight-semibold, which is not defined, with --rs-font-weight-medium in the Drawer title and the Fieldset legend. Both rendered at the inherited weight. The Drawer title now matches the Dialog title.
  • Replace the Fieldset legend's undefined --rs-font-size-base, --rs-line-height-base and --rs-letter-spacing-base with the regular tokens (14px / 20px). The legend took its size from the page.
  • Replace the undefined --rs-font-family in the PromptInput composer with --rs-font-body, the token other components use for body text. The composer took its parent's font.
  • Set the Input prefix and suffix heights to the design: 20px for small (was 16px) and 24px for large (was a fixed 22px that ignored scaling). Both use spacing tokens, so they follow scaling.
  • Match the typography token table to styles/typography.css: line-height-mini is 14px, line-height-t1 is 28px, and body and title letter spacing is in em.

Figma still has the old typography values (Body/Mini line height 16px, Title/T1 24px, letter spacing in px). A separate design task updates Figma to match the code.

@vercel

vercel Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
apsara Ready Ready Preview Oct 19, 2026 8:29am UTC

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@981

commit: 7dcdf39

@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d97d44dd-3ac8-412e-9b71-a29ba44050d3
📥 Commits

Reviewing files that changed from the base of the PR and between 2cfaa03 and 7dcdf39.

📒 Files selected for processing: 5
  • apps/www/src/content/docs/theme/typography/index.mdx
  • packages/react/components/drawer/drawer.module.css
  • packages/react/components/editor/core/editor-core.module.css
  • packages/react/components/fieldset/fieldset.module.css
  • packages/react/components/input/input.module.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Typography documentation updates body and title token values. Styles for the drawer title, editor composer, fieldset legend, and input prefixes and suffixes also change.

Suggested reviewers: rohanchkrabrty

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 7dcdf

This PR updates typography and component sizing; the supplied review evidence identifies no concrete regression, so it is ready for normal checks.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title accurately summarizes the main changes to type tokens, input prefix heights, and typography documentation.
Description check Passed The description directly explains the token replacements, input height updates, and typography documentation changes in the changeset.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Shreyag02 Shreyag02 changed the title token values fix: correct type tokens, input prefix heights and typography docs Oct 19, 2026
@Shreyag02 Shreyag02 self-assigned this Oct 19, 2026

This branch was successfully deployed

1 active deployment
Preview — 7dcdf39f Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant