Skip to content

ci: run the Python tests when the frontend sources they compare change - #1794

Merged
raman325 merged 1 commit into
mainfrom
ci/python-tests-on-ts-changes
Oct 27, 2026
Merged

raman325 merged 1 commit into
mainfrom
ci/python-tests-on-ts-changes

Conversation

@raman325

Copy link
Copy Markdown
Owner

Proposed change

This adds ts/** to the python path filter, so the Python suite runs when a frontend source it reads changes.

tests/test_frontend_contract.py checks the Python constants against ts/const.ts, ts/types.ts, ts/generate-view.ts and ts/add-user-card.ts. Those files only matched the frontend filter. So a frontend-only PR that renamed a key in ts/const.ts, or a field of SlotInfo in ts/types.ts, would skip the contract tests and go green, and the break would surface on the next PR that touches Python.

This commit was meant for #1792. It came out of that PR's review and was pushed after #1792 had already merged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Entire-Checkpoint: 20df4b3769f8
Copilot AI balanced review requested due to automatic review settings October 27, 2026 19:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions github-actions Bot added github-config Changes to .github/ configuration files code-quality Pull requests that improve code quality labels Oct 27, 2026
@raman325
raman325 merged commit 23a3464 into main Oct 27, 2026
13 of 14 checks passed
@raman325
raman325 deleted the ci/python-tests-on-ts-changes branch October 27, 2026 19:35
@codecov

codecov Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.89%. Comparing base (441a75e) to head (9db11cb).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1794      +/-   ##
==========================================
+ Coverage   98.87%   98.89%   +0.01%     
==========================================
  Files          71       72       +1     
  Lines       10165    10299     +134     
  Branches      569      569              
==========================================
+ Hits        10051    10185     +134     
  Misses        114      114              
Flag Coverage Δ
python 99.38% <ø> (+<0.01%) ⬆️
typescript 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality Pull requests that improve code quality github-config Changes to .github/ configuration files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants