Repository navigation
ci: run the Python tests when the frontend sources they compare change - #1794
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Entire-Checkpoint: 20df4b3769f8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1794 +/- ##
==========================================
+ Coverage 98.87% 98.89% +0.01%
==========================================
Files 71 72 +1
Lines 10165 10299 +134
Branches 569 569
==========================================
+ Hits 10051 10185 +134
Misses 114 114
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds
ts/**to thepythonpath filter, so the Python suite runs when a frontend source it reads changes.tests/test_frontend_contract.pychecks the Python constants againstts/const.ts,ts/types.ts,ts/generate-view.tsandts/add-user-card.ts. Those files only matched thefrontendfilter. So a frontend-only PR that renamed a key ints/const.ts, or a field ofSlotInfoints/types.ts, would skip the contract tests and go green, and the break would surface on the next PR that touches Python.This commit was meant for #1792. It came out of that PR's review and was pushed after #1792 had already merged.
Type of change
Additional information
🤖 Generated with Claude Code