Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 65.53% 66.44% +0.91%
==========================================
Files 91 91
Lines 46973 48297 +1324
==========================================
+ Hits 30784 32093 +1309
- Misses 16189 16204 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thanks! I am skeptical about whether this is worth doing at all, because it seems to be impossible to do it correctly. E.g. if you have Maybe we should not try doing this at all, but rather just print out the repositories with a comment that they likely need adjustments. Btw. the |
|
I think it's important to try. Most of the groups promoting I'll look more carefully at the binary path case, though. We should be able to detect it. |
5d68cff to
6c6bccd
Compare
|
We now map |
`rig proj renv import` now reads the package repositories of an renv.lock and turns them into `[[repository]]` entries, instead of leaving every package to resolve from the built-in CRAN. We also make an effort to map known CRAN and Bioconductor aliases to the built-in ones, and turn off these built-in repositories if the `renv.lock` in question doesn't use them (which matches how renv behaves). In addition, we now warn when packages from other sources (e.g. GitHub, GitLab, local) will need manual adjustment. This is progress towards some of the issues raised in #471. Unit tests are included. Signed-off-by: Aaron Jacobs <aaron.jacobs@posit.co>
6c6bccd to
6631e07
Compare
|
I'll delay this a bit until we have worked out how exactly we should handle the different types of repositories. That'll also affect how we convert renv repositories to rig repositories. Soon. |
rig proj renv importnow reads the package repositories of an renv.lock and turns them into[[repository]]entries, instead of leaving every package to resolve from the built-in CRAN. We also make an effort to map known CRAN and Bioconductor aliases to the built-in ones, and turn off these built-in repositories if therenv.lockin question doesn't use them (which matches how renv behaves).In addition, we now warn when packages from other sources (e.g. GitHub, GitLab, local) will need manual adjustment.
This is progress towards some of the issues raised in #471.
Unit tests are included.