Repository navigation
SVG: read currentColor and inherit regardless of case - #2160
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fill="currentcolor"fails withValueError: unsupported color specification currentcolor, becauseinheritable()only recognizes the exact spellingcurrentColor. CSS keywords are case-insensitive, andsvgcolor()already reads color names regardless of case. The Font Awesome icons that WordPress sharing plugins put in web pages are writtenfill="currentcolor"(several pages in trafilatura's and htmldate's test sets have them).inheritable()now comparesinheritandcurrentColorregardless of case and surrounding spaces; non-string values pass through to the converter as before.Added two cases to
test_svg_attribute_conversion; they fail on master. The full test suite passes excepttest_image_with_explicit_dimensions, which also fails on master in my environment; black, pylint, mypy and pyright pass