Repository navigation
SVGObject.from_file: use the encoding the file declares - #2157
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
RavSinghChandan
force-pushed
the
svg-from-file-encoding
branch
from
November 10, 2026 13:05
a42aff4 to
7ec88c5
Compare
RavSinghChandan
force-pushed
the
svg-from-file-encoding
branch
from
November 10, 2026 14:10
7ec88c5 to
356c59b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVGObject.from_file()always decodes the file as UTF-8, so a file that declares another encoding fails:pdf.image("car.svg")reads the same file fine, because it passes the bytes to the XML parser, which uses the declaration.car.svgandpython221imap.svgfrom svglib's test samples both declareiso-8859-1.encodingnow defaults toNone, which reads the bytes and lets the parser use the declared encoding (UTF-8 if there is none, as before). Anencodinggiven explicitly is used as before.Added
test_svg_from_file_encoding(declared Latin-1, UTF-8 without declaration, explicit encoding); the first case fails on master. The full test suite passes excepttest_image_with_explicit_dimensions, which also fails on master in my environment; black, pylint, mypy and pyright pass