Repository navigation
SVG: raise FPDFUnicodeEncodingException for text a core font cannot encode - #2154
Open
RavSinghChandan wants to merge 1 commit into
Open
RavSinghChandan wants to merge 1 commit into
RavSinghChandan wants to merge 1 commit into
Conversation
RavSinghChandan
force-pushed
the
svg-text-core-font-encoding
branch
from
November 10, 2026 13:05
442c349 to
de4c5ae
Compare
andersonhc
approved these changes
Nov 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG text with a character that a core font does not have fails with a bare
KeyErrorfrom the width lookup:The same text in
pdf.cell()raisesFPDFUnicodeEncodingException: Character "–" at index 2 in text is outside the range of characters supported by the font used: "helvetica". Please consider using a Unicode font.(fromnormalize_text()). En dashes,€and arrows are common in SVG diagrams.Text.render()now checks the runs of a core font against its character widths and raises the same exception, with the same font suggestion fromsuggest_unicode_font_for_error(), before measuring the text.Added
test_svg_text_core_font_unsupported_character, which checks that the message equals the one ofcell(); it fails on master. The full test suite passes excepttest_image_with_explicit_dimensions, which also fails on master in my environment; black, pylint, mypy and pyright pass