Repository navigation
SVG: read definitions in a <defs> nested in another <defs> - #2146
Merged
Merged
Conversation
andersonhc
approved these changes
Nov 10, 2026
RavSinghChandan
force-pushed
the
svg-nested-defs
branch
from
November 10, 2026 04:02
cabb9d2 to
4e97ac2
Compare
RavSinghChandan
force-pushed
the
svg-nested-defs
branch
from
November 10, 2026 13:05
4e97ac2 to
c6c3ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_defs()does not recurse into a<defs>inside another<defs>: it logs "Ignoring unsupported SVG tag: " and skips everything in it, so the elements that reference those definitions fail with aKeyError.Berlin_location_map.svg(Wikipedia, in svglib's test samples) has itsclipPath1in<defs id="genericDefs"><defs id="defs1">..., and fails withKeyError: '#clipPath1'. A nested<defs>is valid SVG, andhandle_defs()now reads it like the outer one.Added
test_nested_defs; it fails on master.pytest test/svg test/drawing, black, pylint and mypy pass