Repository navigation
Show tooltips on Packages pane list and detail buttons - #17165
Open
bricestacey wants to merge 2 commits into
Open
bricestacey wants to merge 2 commits into
bricestacey wants to merge 2 commits into
Conversation
Contributor
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. Test count: Linux: 76 tests. |
Button only shows its tooltip when given a hover manager, and the Packages pane never created one, so the website, help, and Update buttons had a tooltip prop that did nothing. Add a usePackagesHoverManager hook and pass its manager to every button with a tooltip. See #15879
ActionBarFilter now creates its own hover manager so its clear and filter buttons show the styled tooltip instead of nothing (clear) or a native title (filter). This applies everywhere the component is used: Packages, Variables, History, the Data Explorer summary bar, and the Object Explorer search. Move the hover manager hook into the platform layer as usePositronActionBarHoverManager and use it from the Packages pane, which replaces usePackagesHoverManager. See #15879
bricestacey
force-pushed
the
15879-tooltips
branch
from
November 9, 2026 16:15
bdb22f2 to
b1d8605
Compare
Comment on lines
+67
to
+68
| // Hover manager hooks. | ||
| const hoverManager = usePositronActionBarHoverManager(); |
Contributor
There was a problem hiding this comment.
We might want to consider accepting a hoverManager as a prop. I could see a scenario where the parent component for this could already have a hover manager which we could reuse here instead of creating one for every actionBarFilter. That is probably the preferred pattern for reusable components like this.
Comment on lines
+22
to
+35
| export const usePositronActionBarHoverManager = (): IHoverManager | undefined => { | ||
| const services = usePositronReactServicesContext(); | ||
| const [hoverManager, setHoverManager] = useState<IHoverManager>(); | ||
| useEffect(() => { | ||
| const disposableStore = new DisposableStore(); | ||
| setHoverManager(disposableStore.add(new PositronActionBarHoverManager( | ||
| true, | ||
| services.configurationService, | ||
| services.hoverService | ||
| ))); | ||
| return () => disposableStore.dispose(); | ||
| }, [services.configurationService, services.hoverService]); | ||
| return hoverManager; | ||
| }; |
Contributor
There was a problem hiding this comment.
Thanks for adding this! We can use this in a few components which currently inline this logic. Opened a follow-up PR to do that: #17232
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button only shows its tooltip when given a hover manager, and the Packages pane never created one, so the website, help, and Update buttons had a tooltip prop that did nothing. Add a usePackagesHoverManager hook and pass its manager to every button with a tooltip.
I also noticed that the Clear and Filter buttons on the ActionBarFilter weren't working, so I fixed that as well.
See #15879
Release Notes
New Features
Bug Fixes
Validation Steps
The buttons can be found on the List and the main Detail pages. I can't get a screenshot with them showing