Skip to content

Add live drawing capacity to the runtime limit vocabulary - #774

Open
luisleo526 wants to merge 6 commits into
mainfrom
fix/live-drawing-limit
Open

luisleo526 wants to merge 6 commits into
mainfrom
fix/live-drawing-limit

Conversation

@luisleo526

Copy link
Copy Markdown
Collaborator

Adds live_drawings to the closed pine_runtime_limit vocabulary so an
operator drawing-capacity refusal can use the existing typed {limit,max}
contract. The code identity, since value and prior limit values remain
stable; the registry, catalog diff, helper documentation and tests are updated.
This change supplies vocabulary for the companion codegen work; it does not
activate drawing enforcement or change collection defaults.

Validation: red-first on baseline be584eb recorded the four expected code
and argument failures for the new 40/100 cases. Candidate b0eb21b passes
5,325 run-failure checks and all 12 catalog-diff module tests using the same
frozen private fixtures. The earlier catalog guard recorded 87 codes and
94 scanned files. Governing review and merge statuses are pending.

🤖 Generated with Claude Code

Accept live_drawings through the existing typed limit helper and publish
its English template, preserving the code identity, since value and prior
limit values. Regenerate the registry and catalog diff and exercise distinct
operator maxima through the real helper contract.
Bring the merged hosted release workflow and its CI documentation and
checks into the candidate without rewriting the existing commits.
Retain the runtime limit catalog addition alongside the current engine changes.

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graphify reviewed this change.

No issues found by static checks — no coupling regressions or blocking issues in the code graph. That is not the same as safe to merge: see what was not checked.

Not checked: tests were not run; no formal proof of the changed code.


Graphify review — findings

Adds live_drawings as a sixth accepted limit value for pine_limit_stop, so a script that keeps more live drawings of one type than the operator's configured capacity can raise the existing nonretryable pine_runtime_limit (class strategy_limit) with {"limit":"live_drawings","max":N}. The catalog and its English template ("The script keeps more than {max} live drawings of one type; the configured drawing capacity is exceeded."), the generated registry and the release diff and checksum are updated to match, and the docs and header comment now list all six limit values. This only extends the helper contract: drawing enforcement and its defaults are unchanged, so nothing raises this code yet. A new test_run_failure_codes test covers the new vocabulary value and its text.

No blocking issues surfaced. 1 lower-confidence candidate did not survive cross-model review.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 2098 functions depend on the 165 functions this change touches.

Health — grade B; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • commit_input — 32 callers, 14 callees (high)
  • verify_report — 18 callers, 10 callees (high)
  • make_run_failure() — 12 callers, 10 callees (high)
  • strategy_native_submit_v1() — 19 callers, 6 callees (high)
  • consume_matched_request — 2 callers, 43 callees (high)
  • begin_ready — 4 callers, 21 callees (high)
  • run() — 1 callers, 73 callees (high)
  • match_path — 2 callers, 35 callees (high)
  • …and 2 more

Verification — 2098 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 2069 function(s) in the blast radius were not formally verified this run

Point seven documentation citations at the matching catalog fields after the vocabulary additions shifted their lines.
Keep the live drawing vocabulary and documentation corrections with the current cohort admission behavior.
Retain the runtime vocabulary change and the current input conversion documentation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant