Repository navigation
Conversation
|
@kruschdev is attempting to deploy a commit to the Pascal Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a two-way round-trip gap in
humanizeDateRange(plan 030, plan 007) wheresecond-grain endpoints and sub-minute anchored ranges lost their seconds on humanize.formatClockpreviously rendered onlyHH:MM, turning9:00:30am to 5:00:45pminto"9:00 AM to 5:00 PM"and2026-07-03T09:00:30 to 2026-07-03T17:00:45into"2026-07-03 9:00 AM to 2026-07-03 5:00 PM", which re-parsed atminutegrain with truncated seconds. I updatedformatClockto render:SSwhenever an endpoint carriessecondgrain or a non-zerogetSeconds().anchoredPhrasepreviously operated in whole minutes (m = diff / 6e4), dropping anchor seconds on"10 minutes starting 2026-07-03T09:00:30"and returningnullon sub-minute anchored durations like"30 seconds starting 2026-07-03T09:00:15", which then fell through to bare"9:00 AM to 9:00 AM"without its calendar date or seconds. I updatedanchoredPhraseto compute exact civil seconds so second-unit durations and second-grain anchors round-trip cleanly ("30 seconds starting 2026-07-03 9:00:15 AM"), and ensured non-integer anchored fallbacks keep their calendar date.Checklist
Gates
bun run checkgreen (typecheck, tests, build, size budgets, corpus gate, zero-deps gate)bun run lintgreen (Biome via Ultracite)API surface
humanizeDateRange)Knowledge layer
[Unreleased]plans/backlog.md