Repository navigation
Conversation
|
@kruschdev is attempting to deploy a commit to the Pascal Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes minor-currency range distribution in
buildRange(plan 026, plan 004) when one endpoint is a bare number and the other uses a minor-currency idiom (cents,¢,pence,p).matchCurrencyMinorreturned{ kind: 'currency', headUnit: 'USD', base: 0.06 }for"6 cents"without recording its minor-unit scale (100). InbuildRange, a bare endpoint ("5"in"5 to 6 cents","5 or 6 cents","5-6 cents","between 5 and 6 cents","5 to 6 pence") inherited the major currency unit ($5.00/£5.00) instead of scaling by100, then trippedaBase > bBaseand returned0.06–$5.00with a falseRANGE_REVERSEDwarning.minorScaleonQtyNodefor standalone minor-currency hits sobuildRangescales bare left or right endpoints by the paired minor scale (0.05–$0.06,0.05–£0.06), while still flagging genuinely reversed minor ranges ("6 to 5 pence"->0.05–£0.06+RANGE_REVERSED).QuantityResultconstruction insingleResult(parse/range.ts) with identical semantics so./corestays within its27.1 kBmin+gzip budget (27.07 kB).Checklist
Gates
bun run checkgreen (typecheck, tests, build, size budgets, corpus gate, zero-deps gate)bun run lintgreen (Biome via Ultracite)+5minor-currency range rows intests/corpus/source.mjsandcontract-v1.json, zero changes to existing rows)API surface
RANGE_REVERSEDon minor-currency ranges)Knowledge layer
[Unreleased]plans/backlog.md