Repository navigation
Add reproducible cohort RNA analysis and sequence-rich PDF reports - #594
Conversation
iskandr
left a comment
There was a problem hiding this comment.
Reviewed the shipped #594 changes at merge commit 749d92a (Isovar 1.62.0). Found three reproducible issues:
-
[P1] Bind render-only results to their recorded identity — cohort.py:370-376. Reusing a source/pass directory after changing sample, library or analysis settings silently renders old evidence under the new manifest. A one-variant COLO829 fixture produced HCC1395_RNA_evidence.pdf after changing only manifest identity/settings; the embedded receipt still identified COLO829 and its old window size. Tracked with reproduction and acceptance criteria in #596.
-
[P2] Allow a valid translated fusion without a coding acceptor comparator — cohort_pdf.py:359. reconstruct_fusion legitimately returns translated MAAKGPFE with donor-only references and acceptor_frames=[], but the renderer raises IndexError and aborts report generation. Tracked in #597.
-
[P2] Correct partial-fusion and insertion offsets in parental reference rows — cohort_pdf.py:363-370. Donor indexing omits translation_start; acceptor indexing uses the start rather than the end of an inserted junction interval. Existing synthetic fixtures reproduce an AAK donor segment displayed against MAA and an acceptor GPFE row shifted one residue left after a GCT insertion. This misclassifies unchanged parental residues as non-reference. Tracked in #598.
Validation: 247 focused existing tests passed (cohort, PDF alignment helpers, coding interval support, protein hypotheses, contig aliases, variant RNA ORFs and fusion). The new isolated reproductions demonstrate coverage gaps despite those passing tests. No production code was changed during this review.
These are follow-up fixes to the released change; this review does not assert that the unchanged COLO829/HCC1395/Sid manifests exhibited the stale-manifest case.
The COLO829, HCC1395 and Sid analyses previously required separate report scripts, and context-contributing RNA fragments could be mistaken for reads spanning an entire protein window. This adds
isovar cohort/isovar-cohort: a source-separated manifest workflow over the existing small-variant, ncORF, SV, supplied-fusion, viral and isoform APIs, with landscape and sequence-comparison PDFs.Validation:
./lint.shpassed; the local./test.shrun passed 6,452 tests; 95 focused cohort/CLI/report checks include the added unavailable-source cases.pip checkpassed in the isolated release environment. All three real-data PDFs were rendered and visually reviewed; pending inputs are excluded from measured funnels. GitHub CI must pass on the final revision before merge and release.Scope: whole-library viral discovery/alignment remains an input-preparation step. The dense full-library SV inventory performance problem is tracked separately in #593; missing or incomplete analyses remain explicit, never negative evidence. Patient-background peptide pairs (#100) and downstream per-placement SV support (#589) remain follow-ups. Public contig-resolution API consolidation is tracked in openvax/varcode#645.
Closes #592. Advances #590 and #591.