Repository navigation
Model refresh functionality. To trigger the signal on every derivate … - #187
Merged
Merged
Conversation
…of Cache. We don't assign the model directory, but take it from the base configuration, to be able to update base configuration and refresh.
Change strange Yoda-like not is none if statement. Add comment to the ilidata_direcotries
gacarrillor
approved these changes
Oct 27, 2026
gacarrillor
left a comment
gacarrillor
left a comment
Member
There was a problem hiding this comment.
Another "I trust you" review :)
Member
Author
Thanks. Sometimes it's already good when someone looks quickly over the code. Since it's not vibe coded you can assume that someone made his thoughts about it :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having IliCache more powerful used for updating it with new custom directories configured in the base_configuration.
We don't assign the model directory, but take it from the base configuration, to be able to update base configuration and refresh.
As well we have a proper signal on model refresh (not only on IliDataCache (based on IliCache) but as well on IliCache)...