Repository navigation
Conversation
gaussianBlur took a strength but ignored it, so the software GlowFilter and DropShadowFilter of OpenFL drew a faint halo for any strength. As in Flash, the blurred alpha is now multiplied by the strength, up to opaque. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Flash, the pixels of an Image are in a flash.display.BitmapData, not in the data that gaussianBlur reads, so the test failed on AIR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageDataUtil.gaussianBlur()takes astrengthbut ignored it. OpenFL'ssoftware
GlowFilterandDropShadowFilterpass theirs to it, so on the Cairorenderer and in
BitmapData.draw(), a glow or a shadow came out as the samefaint halo whatever its strength. Flash multiplies the blurred alpha by the
strength, which is how a glow of strength 4 gives text a solid outline.
The blurred alpha is now multiplied by the strength and clamped to opaque, over
the pixels that the blur wrote. A strength of 1 leaves the result unchanged.
Test:
graphics.ImageDataUtilTestblurs a dot with strengths 1, 4 and 255.Without the fix the alpha stays the same for all three (
expected 40 but it is 10); with it, the test passes on neko. In a Linux cpp repro, a text fieldwith a
GlowFilterdrew the same pixels at strength 1, 4 and 50 before thefix. After it, strengths 1 and 4 give different pixels.