Repository navigation
Conversation
|
Hello, don't know if you have finish, here is some pre-review:
|
|
Sorry, I forgot to set this PR as draft. It is not ready at all and I don't know if I'm tacking this the right way. |
|
Ok, you may have a look to openfisca/openfisca-france#2547 |
Simplify a lot to pass CI
Moved to a single strategy job
|
Oh many thanks and sorry @benjello I did not meant to use you to run agent AI on the failing job but more globally to have your feedback on the documented changes. |
|
No pb |
|
@benjello, @benoit-cty and @openfisca/international-maintainers eager to get your feedback and reviews |
|
Nice work. |
|
From memory I kept |
benjello
left a comment
There was a problem hiding this comment.
Nice work to have uv and pyproject
benoit-cty
left a comment
There was a problem hiding this comment.
Please do not merge, Comming soon...
Fixes to PR #1396 (pip → uv migration) after code reviewA review of #1396 found 10 issues. Four of them would have stopped the release pipeline (nothing published to PyPI, no tag pushed), and one silently disabled every doctest. This document lists each fix and why it was needed. Release pipeline1. Invalid reusable workflow path —
|
| Check | Result |
|---|---|
make test-code with pytest 8.3.3 (lowest allowed) |
✅ pass (core doctests included) |
make test-code with pytest 9.1.1 |
✅ pass |
make test-core openfisca_args="--in-parallel" with pytest 9 |
✅ pass |
make lint |
✅ pass |
make install |
✅ pass |
is-version-number-acceptable.sh |
✅ reads 46.0.0, exits 0 |
All workflow and Dependabot YAML files parse; has-functional-changes has no trailing newline |
✅ |
make check-types |
The GitHub Actions changes (1, 2, 4, 7) can only be fully checked on GitHub: by a merge to main, or by running windows-test.yaml by hand through workflow_dispatch.
benoit-cty
left a comment
There was a problem hiding this comment.
I've checked that the PyPI trusted publishing was already setup.
|
@benoit-cty from your comment I understand you pushed a commit on the branch with fixes but it is not the case. Am I understanding it wrongly? |
Breaking changes
devis moved to[dependency-groups]/devinpyproject.tomltrackeras it is not maintained nor usedTechnical changes
piptouvfor package managementuv--resolution=[highest, lowest-direct]in CI to ensure a large test coverage on multiplenumpyversionssetup.pyandsetup.cfgand move logic topyproject.tomlQuestions
trackerreally be removed?Comment
I already set up https://pypi.org/manage/project/OpenFisca-Core/settings/publishing/