Repository navigation
fix: restore build:wasm npm script - #6009
Merged
Merged
Conversation
The llhttp build script was renamed from build:wasm to build:llhttp in #5954. Node.js core's tools/dep_updaters/update-undici.sh invokes `npm run build:wasm`, so the automated undici update for v8.12.0 fails with `Missing script: "build:wasm"`. Restore build:wasm with the same command as build:llhttp so downstream tooling keeps working. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFcdjGCJYJoZW6iJt2DUh3 Signed-off-by: Matteo Collina <hello@matteocollina.com>
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6009 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 113 113
Lines 43679 43679
=======================================
Hits 39999 39999
Misses 3680 3680 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5954 renamed the llhttp build script from
build:wasmtobuild:llhttp. Node.js core'stools/dep_updaters/update-undici.shrunsnpm run build:wasm, so the automated undici update for v8.12.0 fails:Failing run: https://github.com/nodejs/node/actions/runs/38540716262/job/115774489408#step:5:82
This PR adds
build:wasmback, running the same command asbuild:llhttp, so downstream tooling keeps working. Its stdout matches the old script, which matters because Node saves it tolib/llhttp/wasm_build_env.txt.We will need a patch release (v8.12.1) to unblock the Node.js update.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LFcdjGCJYJoZW6iJt2DUh3