Skip to content

fix: restore build:wasm npm script - #6009

Merged
mcollina merged 1 commit into
mainfrom
fix/restore-build-wasm-script
Oct 14, 2026
Merged

mcollina merged 1 commit into
mainfrom
fix/restore-build-wasm-script

Conversation

@mcollina

Copy link
Copy Markdown
Member

#5954 renamed the llhttp build script from build:wasm to build:llhttp. Node.js core's tools/dep_updaters/update-undici.sh runs npm run build:wasm, so the automated undici update for v8.12.0 fails:

+ node deps/npm/bin/npm-cli.js run build:wasm
npm error Missing script: "build:wasm"

Failing run: https://github.com/nodejs/node/actions/runs/38540716262/job/115774489408#step:5:82

This PR adds build:wasm back, running the same command as build:llhttp, so downstream tooling keeps working. Its stdout matches the old script, which matters because Node saves it to lib/llhttp/wasm_build_env.txt.

We will need a patch release (v8.12.1) to unblock the Node.js update.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LFcdjGCJYJoZW6iJt2DUh3

The llhttp build script was renamed from build:wasm to build:llhttp in
#5954. Node.js core's tools/dep_updaters/update-undici.sh invokes
`npm run build:wasm`, so the automated undici update for v8.12.0 fails
with `Missing script: "build:wasm"`.

Restore build:wasm with the same command as build:llhttp so downstream
tooling keeps working.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LFcdjGCJYJoZW6iJt2DUh3
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina
mcollina merged commit 9a47f91 into main Oct 14, 2026
37 checks passed
@mcollina
mcollina deleted the fix/restore-build-wasm-script branch October 14, 2026 09:21
@github-actions github-actions Bot mentioned this pull request Oct 14, 2026
@codecov-commenter

codecov-commenter commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.57%. Comparing base (6f98fcc) to head (3392c13).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6009   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         113      113           
  Lines       43679    43679           
=======================================
  Hits        39999    39999           
  Misses       3680     3680           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants