Repository navigation
Conversation
Non-UTF-8 bytes in captured test output cause Execute() to raise UnicodeDecodeError. CI reports can then attribute the failure to an earlier, expected "Error: uncaught" message from a passing cctest. Replace malformed UTF-8 in stdout and stderr so the runner reports test results while preserving the child process exit status. Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-10-16.md Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
the
flaky-test
nodejs-github-bot
added
needs-ci
panva
added
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66783 +/- ##
==========================================
- Coverage 90.49% 90.49% -0.01%
==========================================
Files 797 797
Lines 277598 277598
Branches 53332 53337 +5
==========================================
- Hits 251216 251213 -3
+ Misses 16798 16793 -5
- Partials 9584 9592 +8 🚀 New features to boost your workflow:
|
richardlau
approved these changes
Oct 16, 2026
panva
added
the
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
panva
added
the
commit-queue
UlisesGascon
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-UTF-8 bytes in captured test output cause Execute() to raise UnicodeDecodeError. CI reports can then attribute the failure to an earlier, expected "Error: uncaught" message from a passing cctest.
Replace malformed UTF-8 in stdout and stderr so the runner reports test results while preserving the child process exit status.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-10-16.md
Assisted-by: Codex