Skip to content

docs: fix versionRange empty-string description - #380

Merged
ChampionAsh5357 merged 3 commits into
neoforged:mainfrom
sonawaneutkarsh:modtoberfest/fix-versionrange-docs
Oct 24, 2026
Merged

ChampionAsh5357 merged 3 commits into
neoforged:mainfrom
sonawaneutkarsh:modtoberfest/fix-versionrange-docs

Conversation

@sonawaneutkarsh

@sonawaneutkarsh sonawaneutkarsh commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

summary
fixed incorrect desc about versionRange handling empty strings

changes

  • clarifies that empty string matches no versions
  • added "*" as the correct wildcard for matching any version

this altogether fixes #362


Preview URL: https://pr-380.neoforged-docs-previews.pages.dev

@ChampionAsh5357 ChampionAsh5357 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion, we agree that * is the best solution, since the actual solution currently crashes. However, your change does not seem to address the bugs with this statement.

Comment thread docs/gettingstarted/modfiles.md Resolved
@sonawaneutkarsh

Copy link
Copy Markdown
Contributor Author

ur right, mb. ill push a fix. the default in the table is now "" instead of "".
dropped the empty string sentence and the desc just says "
" matches any version.

@ChampionAsh5357 ChampionAsh5357 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update for all the other doc versions as well.

Comment thread docs/gettingstarted/modfiles.md Resolved
@neoforged-pages-deployments
neoforged-pages-deployments Bot deployed to neoforged-docs-previews (Preview) October 24, 2026 13:18 Active
@neoforged-pages-deployments

Copy link
Copy Markdown

Deploying with Cloudflare Pages

Name Result
Last commit: a5dba543e225dcf1ff2cb37302ba38a93981d074
Status: ✅ Deploy successful!
Preview URL: https://7a45982e.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-380.neoforged-docs-previews.pages.dev

@ChampionAsh5357
ChampionAsh5357 merged commit c203384 into neoforged:main Oct 24, 2026
1 check passed

This branch was successfully deployed

1 active deployment
neoforged-docs-previews (Preview) — a5dba543 Deployed Oct 24, 2026 by neoforged-pages-deployments[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependency version wildcard is incorrect

2 participants